Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically convert numeric arguments passed to any Redis commands #171

Merged
merged 1 commit into from
Feb 2, 2025
Merged

Automatically convert numeric arguments passed to any Redis commands #171

merged 1 commit into from
Feb 2, 2025
+89 −21

Conversation

clue
Copy link
Owner

@clue clue commented Feb 2, 2025

This changeset makes sure we automatically convert numeric arguments passed to any Redis commands. This is particularly useful when using the new callAsync() method with static analysis tools:

// old (still supported)
$redis->callAsync('SET', 'name', 'Alice', 'EX', '60');

// new
$redis->callAsync('GET', 'name', 'Alice', 'EX', 60);

Builds on top of #166, #140, #128, #127 and others

@clue clue added this to the v3.0.0 milestone Feb 2, 2025
@clue clue merged commit 39aa211 into clue:3.x Feb 2, 2025
18 checks passed
@clue clue deleted the numeric-args branch February 2, 2025 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
new feature
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@clue